-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Integrate beta messaging with Add Data #71147
Conversation
…ls, and use registered components when rendering tutorial directory
…and use registered components when rendering tutorial page
…as optional plugin dep; register tutorial module notice
…nager global setting field
…missible directory notice via observable
Pinging @elastic/ingest-management (Team:Ingest Management) |
Pinging @elastic/kibana-core-ui (Team:Core UI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as described, nice job! 👍
Also, thanks for the detailed testing description.
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
) * Add methods to register directory notices and header links in tutorials, and use registered components when rendering tutorial directory * Add methods to register module notices components in tutorial pages, and use registered components when rendering tutorial page * Add `moduleName` field to server tutorial schema and test fixure * Surface `moduleName` field from built in tutorials and registered apm tutorial * Export component types * Add KibanaContextProvider to home plugin app render * Move setHttpClient to ingest manager plugin setup() method; add home as optional plugin dep; register tutorial module notice * Fix key prop warnings * Add dismissable tutorial directory notice and corresponding ingest manager global setting field * Add tutorial directory header link and tie it to the state of the dismissible directory notice via observable * Put spacing inside module notice component itself * Check if ingest manager is available in current space Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/home/server/tutorials/oracle_metrics/index.ts
Resolves #69048
Resolves #70384
Summary
This PR adds Ingest Manager Beta messaging to Kibana's Add Data tutorial directory and tutorial module pages:
HomePublicPluginSetup
interface that allows for custom components to be injected into Home > Add data:tutorial.registerDirectoryNotice()
registers a component that will be displayed on main Add data directory pagetutorial.registerDirectoryHeaderLink()
registers a component that will be displayed on the right of Add data directory page title arearegisterModuleNotice()
registers a component that will be displayed under the description of an Add data module tutorial pagemoduleName?: string;
toTutorialSchema
and surface the module name of existing tutorials, where applicable (I believe a few tutorials are not associated with modules, such asEMS Boundaries
)moduleName
variable which I simply surfaced. I attempted to add ones which didn't, and would appreciate reviews for those ones I added.home
plugin as an optional dependency to Ingest Manager pluginhome
plugin is available, registers them during Ingest Manager pluginsetup()
lifecyclehas_seen_add_data_notice
field to Ingest Manager global settings saved objecthas_seen_add_data_notice
is set to true, preventing the notice from being seen again on refreshTesting
AWS Cloudwatch logs
orMySQL logs
If Ingest Manager is not available as a feature in the current space, no Ingest Manager Beta messaging should appear in Add data.
If you want to get the dismissible callout back, you can clear your setting by:
Screenshots